Skip to content

Revert "ble: Remove CONFIG_BT_BUF_ACL_RX_COUNT" #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Revert "ble: Remove CONFIG_BT_BUF_ACL_RX_COUNT" #670

merged 1 commit into from
Jan 7, 2025

Conversation

@RobertGalatNordic
Copy link
Collaborator

@RobertGalatNordic RobertGalatNordic commented Jan 7, 2025

Reverts #664

Change in NRF is still not ready

@github-actions github-actions bot added the source PR changing src files label Jan 7, 2025
@RobertGalatNordic
Revert "ble: Remove CONFIG_BT_BUF_ACL_RX_COUNT"
29f1ab4 
This reverts commit f274ce8.

Signed-off-by: Robert Gałat <[email protected]>
@RobertGalatNordic RobertGalatNordic force-pushed the revert-664-remove_bt_buf_acl_rx_count branch from a2d9200 to 29f1ab4 Compare January 7, 2025 09:11
@ktaborowski
Copy link
Contributor

ktaborowski commented Jan 7, 2025

@PavelVPV it seems nrfconnect/sdk-nrf#19412 was not merged in nrf, please reopen Sidewalk pr when ready to merge in nrf

@github-actions
Copy link

github-actions bot commented Jan 7, 2025

Sample diff used total
nrf52840dk/nrf52840:sample.sidewalk.demo RAM 0 B 123.64 KB 0 B
ROM 128 B 478.92 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.demo.ble_only RAM 0 B 108.3 KB 0 B
ROM 144 B 396.45 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut RAM 0 B 147.28 KB 0 B
ROM 128 B 544.9 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.ble_only RAM 0 B 131.88 KB 0 B
ROM 128 B 461.79 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo RAM 0 B 121.57 KB 0 B
ROM 1.61 KB 457.74 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 106.52 KB 0 B
ROM 1.6 KB 379.98 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut RAM 0 B 145.32 KB 0 B
ROM 1.6 KB 524.2 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.ble_only RAM 0 B 130.21 KB 0 B
ROM 1.6 KB 445.91 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo RAM 0 B 121.57 KB 0 B
ROM 1.6 KB 457.77 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.demo.ble_only RAM 0 B 106.52 KB 0 B
ROM 1.6 KB 380.01 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut RAM 0 B 145.32 KB 0 B
ROM 1.61 KB 524.24 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.ble_only RAM 0 B 130.21 KB 0 B
ROM 1.6 KB 445.95 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo RAM 0 B 120.79 KB 0 B
ROM 136 B 406.43 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.demo.ble_only RAM 0 B 105.74 KB 0 B
ROM 120 B 328.68 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut RAM 0 B 144.54 KB 0 B
ROM 120 B 473.13 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.ble_only RAM 0 B 129.44 KB 0 B
ROM 120 B 394.84 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.dut.no_secure RAM 0 B 147.26 KB 0 B
ROM 144 B 536.36 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello RAM 0 B 124.87 KB 0 B
ROM 128 B 494.23 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only RAM 0 B 98.12 KB 0 B
ROM 128 B 394.78 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.dut.no_secure RAM 0 B 145.3 KB 0 B
ROM 1.61 KB 516.52 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello RAM 0 B 123.01 KB 0 B
ROM 1.6 KB 473.02 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 96.57 KB 0 B
ROM 1.62 KB 378.3 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.dut.no_secure RAM 0 B 145.3 KB 0 B
ROM 1.61 KB 516.55 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello RAM 0 B 123.01 KB 0 B
ROM 1.6 KB 473.06 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only RAM 0 B 96.57 KB 0 B
ROM 1.61 KB 378.32 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.dut.no_secure RAM 0 B 144.54 KB 0 B
ROM 120 B 470.42 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello RAM 0 B 122.24 KB 0 B
ROM 120 B 421.72 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only RAM 0 B 95.79 KB 0 B
ROM 136 B 326.99 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.ble_only.release RAM 0 B 93.31 KB 0 B
ROM 128 B 325.39 KB 0 B
nrf52840dk/nrf52840:sample.sidewalk.hello.release RAM 0 B 108.67 KB 0 B
ROM 128 B 404.36 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 91.93 KB 0 B
ROM 1.61 KB 306.86 KB 0 B
nrf54l15dk/nrf54l10/cpuapp:sample.sidewalk.hello.release RAM 0 B 106.99 KB 0 B
ROM 1.62 KB 382.74 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.ble_only.release RAM 0 B 91.93 KB 0 B
ROM 1.62 KB 306.89 KB 0 B
nrf54l15dk/nrf54l15/cpuapp:sample.sidewalk.hello.release RAM 0 B 106.99 KB 0 B
ROM 1.62 KB 382.77 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.ble_only.release RAM 0 B 91.16 KB 0 B
ROM 136 B 256.49 KB 0 B
nrf54l15dk/nrf54l15/cpuapp/ns:sample.sidewalk.hello.release RAM 0 B 106.21 KB 0 B
ROM 120 B 332.35 KB 0 B

@RobertGalatNordic RobertGalatNordic merged commit 7767d43 into main Jan 7, 2025
47 of 48 checks passed
@RobertGalatNordic RobertGalatNordic deleted the revert-664-remove_bt_buf_acl_rx_count branch January 7, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ktaborowski ktaborowski ktaborowski approved these changes

Assignees

No one assigned

Labels

source PR changing src files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RobertGalatNordic @ktaborowski